Filter task separated in its own task dptdpt-filter#265
Conversation
It feeds - match-reco-gen independent separated from the filter-qa task - dptdptcorrelations independent - dptdpt-filter-qa independent separated from the match-reco-gen task
victor-gonzalez
requested review from
alibuild,
jgrosseo and
saganatt
as code owners
|
The filter task produce a filtered table for use of dptdpt correlations, the matching reco-gen and the filter-qa. By the way, up to eight different process functions for the same functionality and almost no code replicated!! |
jgrosseo
left a comment
jgrosseo
left a comment
There was a problem hiding this comment.
See some comments inline
| } // namespace dptdptfilter | ||
| DECLARE_SOA_TABLE(AcceptedEvents, "AOD", "ACCEPTEDEVENTS", //! Accepted reconstructed collisions/events filtered table | ||
| o2::soa::Index<>, | ||
| collision::BCId, |
There was a problem hiding this comment.
Why do you keep the BCid?
Do you need the timestamp to later retrieve the magnetic field (or directly the magnetic field)?
There was a problem hiding this comment.
Not really. I introduced it when we were tracking the reco-gen issues
I will keep it for a while and probably remove it at the end unless I find a way to remove close pairs the way you do without affecting the correlators (which is not the case today). But perhaps in that case directly the magnetic field will be better
There was a problem hiding this comment.
Yes, another way to remove close pairs is better...
| collision::BCId, | ||
| collision::PosZ, | ||
| dptdptfilter::EventAccepted, | ||
| dptdptfilter::EventCentMult); |
There was a problem hiding this comment.
Do you miss an index to acceptedTrueEvent here?
There was a problem hiding this comment.
So far, once filtered, the detector level and the generator level are completely independent and no need to link them
Also - getting rid of long qualifiers for int - using float pi constants
|
Strange. In both |
* PWGLF: Add Nsigma-TOF at analysis time: first test * Please consider the following formatting changes (#265) * Modifications for further exploratory studies * Fix problematic use of filters * Please consider the following formatting changes (#266) * Update cascademcfinder.cxx --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
…Group#5327) * PWGLF: Add Nsigma-TOF at analysis time: first test * Please consider the following formatting changes (AliceO2Group#265) * Modifications for further exploratory studies * Fix problematic use of filters * Please consider the following formatting changes (AliceO2Group#266) * Update cascademcfinder.cxx --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
…Group#5327) * PWGLF: Add Nsigma-TOF at analysis time: first test * Please consider the following formatting changes (AliceO2Group#265) * Modifications for further exploratory studies * Fix problematic use of filters * Please consider the following formatting changes (AliceO2Group#266) * Update cascademcfinder.cxx --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
2 participants
It feeds